Conversation
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
pimlock
approved these changes
Apr 24, 2026
Collaborator
pimlock
left a comment
pimlock
left a comment
There was a problem hiding this comment.
Maybe worth calling this out somewhere that was a breaking change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the Rust e2e upload tests to match the new basename-preserving directory upload semantics introduced in #952. This fixes the
e2e / E2E (rust)regression from run 24874464695.Related Issue
Regression from #952
Failed workflow: https://github.com/NVIDIA/OpenShell/actions/runs/24874464695/job/72828948289
Changes
upload_createto read directory uploads from/sandbox/data/project/...syncround-trip expectations for directory downloads after upload.gitignorefiltered upload test to verify the nested repo directoryTesting
mise run pre-commitpassescargo fmt --all -- --checkRUSTC_WRAPPER= CARGO_BUILD_JOBS=1 cargo test --manifest-path e2e/rust/Cargo.toml --features e2e --test sync --no-runRUSTC_WRAPPER= CARGO_BUILD_JOBS=1 cargo test --manifest-path e2e/rust/Cargo.toml --features e2e --test upload_create --no-runmise run pre-commitcurrently fails locally inrust:checkbecausesccachehitsToo many open filesChecklist